Add Strike Team: Core Engagement plugin#190
Add Strike Team: Core Engagement plugin#190AATheBuilder wants to merge 1 commit intoagent0ai:mainfrom
Conversation
Plugin submission validation failedERROR: PR must modify exactly one plugin folder under plugins/ |
9a45a56 to
34ed7e6
Compare
|
Hello @AATheBuilder I went through the plugin's code, and I have this review for you. Secrets & Sensitive Data Access — 🔴 Fail
"""
Capture harvested credentials, keys, or sensitive data (loot)
and store it in the structured recon memory.
"""
async def execute(self, target: str, kind: str, value: str, username: str = "", context: str = "", **kwargs) -> Response:Risk: The tool explicitly solicits credentials, keys, and other sensitive material as normal input. That means the plugin is designed to handle secrets directly, increasing exposure risk anywhere it is enabled. It should handle them using the secrets manager wrapper Secrets & Sensitive Data Access — 🔴 Fail
# Create Loot entity
loot_val = f"{kind}:{username}" if username else f"{kind}:{value[:20]}..."
loot_entity = _upsert_entity(
data,
entity_type="Loot",
value=loot_val,
properties={
"kind": kind,
"secret": value, # NOTE: In a real prod env, this should be encryptedRisk: The code persists the raw secret value into the plugin’s recon memory without encryption. That creates durable plaintext exposure of harvested credentials or tokens to anyone who can read the Agent Zero workdir, logs, snapshots, or backups during an attack. Have a good one and let me know if you need any more info, |
Hey! I didn't consider that - I will run through it again and find another way to store the data. Thank you. |
|
All done bro! Please let me know if it is OK? |
Elite engagement suite with Objective Dominance prompts, structured Vault memory, and Hunter Recon Sync.