refactor(_model_config): componentize model config, split store into mixins, unify API key management#1374
Conversation
Development
…t store into mixins, unify API key lifecycle
…ved via Configure Models
nicolasleao
left a comment
There was a problem hiding this comment.
Nice refactor overall. Consolidating the repeated model UI and splitting store concerns makes a lot of sense.
There's a potential regression around the preset Utility Model fallback behavior:
-
In
model-field.html, the store-backed API key branch uses model.provider directly instead of the fallback-aware provider (providerFallback / _prov). For utility presets with no explicit provider, the API key reveal/status/save path may stop following the intended fallback to the main model provider. -
The shared provider
<select>no longer appears to include an empty option, which may make it impossible to set the Utility preset provider back to “blank = use fallback/default behavior.”
I don't have full context here, so please point out if I'm wrong
Thanks for the feedback, the issue has been fixed. |
Bug Fix