Skip to content

fix(skills): retire stale steward supplier refs; sharpen origin-skill provenance (#74)#75

Merged
OriNachum merged 1 commit into
mainfrom
fix/74-skill-family-nits
Jul 15, 2026
Merged

fix(skills): retire stale steward supplier refs; sharpen origin-skill provenance (#74)#75
OriNachum merged 1 commit into
mainfrom
fix/74-skill-family-nits

Conversation

@OriNachum

Copy link
Copy Markdown
Contributor

What

Lands the intended fix for the devague origin-skill family at source, so
rollout-cli can resume its paused mesh broadcast (24 PRs open, 46 pending) and
the fix propagates on the downstream re-pull — rather than being chased across
70+ downstream copies. Closes #74.

Docs/comments only. Three small cleanups across the six origin skills:

1. stewardguildmaster (stale mesh-supplier name)

The three wrapper scripts (think.sh, spec-to-plan.sh,
assign-to-workforce.sh) and the test_think_skill docstring still named
steward as the mesh supplier in their # Origin: headers. That role moved to
guildmaster at the 2026-05-24 cutover, and every SKILL.md already says so
— these were the last stale references, and they would have shipped verbatim
to every downstream copy on the broadcast.

2. otherinbound skills (imprecise wording)

The think / spec-to-plan / assign-to-workforce / deviate descriptions
said they are "not vendored from guildmaster like the other skills here."
The other origin skills are also not vendored from guildmaster, so "other" was
imprecise. Reworded to "inbound", matching scope and summarize-delivery.

3. scope provenance refresh

scope's Provenance called it "the fourth in the outbound family after
/think, /spec-to-plan, and /assign-to-workforce"
— which reads as if it
pre-dates the two later siblings. Clarified that the "fourth" ordinal is
authoring order while scope's role is the opening leg of the flow, and
added the never-re-vendored-back upstream clause its younger siblings
(summarize-delivery, deviate) already carry.

Testing

  • uv run pytest -n auto614 passed
  • markdownlint-cli2 CHANGELOG.md — clean
  • bash -n on all three wrapper scripts — clean
  • black --check + flake8 on the touched test — clean

Version

Patch bump 0.18.00.18.1 with a ### Fixed CHANGELOG entry.

Follow-up for rollout-cli

Once merged, this unblocks #74: rollout-cli can refresh the 24 open PRs from the
fixed source and complete the remaining 46 pending repos.

  • devague (Claude)

…ll provenance (0.18.1, #74)

Land the intended fix for the devague origin-skill family at source, before
rollout-cli resumes its paused mesh broadcast (24 PRs open, 46 pending) — so
the fix propagates on the downstream re-pull instead of being chased across
70+ copies.

- steward→guildmaster: the three wrapper scripts (`think.sh` /
  `spec-to-plan.sh` / `assign-to-workforce.sh`) and the `test_think_skill`
  docstring still named `steward` as the mesh supplier. That role moved to
  `guildmaster` at the 2026-05-24 cutover, and every `SKILL.md` already says
  so; these were the last stale references and would have shipped verbatim
  downstream.
- other→inbound: the `think` / `spec-to-plan` / `assign-to-workforce` /
  `deviate` descriptions said they are "not vendored like the other skills
  here." The other origin skills are also not vendored from guildmaster, so
  "other" was imprecise — reworded to "inbound", matching `scope` and
  `summarize-delivery`.
- scope provenance: clarified that its "fourth" ordinal is authoring order
  while its role is the opening leg of the flow, and added the
  never-re-vendored-back upstream clause its younger siblings already carry.

Docs/comments only; 614 tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LYjiRW7pVrEjTpZYGvPaEg
@OriNachum

Copy link
Copy Markdown
Contributor Author

/agentic_review

@qodo-code-review

qodo-code-review Bot commented Jul 15, 2026

Copy link
Copy Markdown

Code Review by Qodo

Grey Divider

New Review Started

This review has been superseded by a new analysis

Grey Divider

Qodo Logo

@sonarqubecloud

Copy link
Copy Markdown

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix origin-skill provenance text and update mesh supplier refs (0.18.1)

🐞 Bug fix 📝 Documentation ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Replace stale steward mesh-supplier references with guildmaster in origin headers.
• Clarify origin-skill provenance wording: “other” → “inbound”, and refine scope’s flow position.
• Cut patch release 0.18.1 with a Fixed changelog entry to propagate via broadcast.
Diagram

graph TD
A["agentculture/devague"] --> B["Origin skills (SKILL.md)"] --> C["guildmaster broadcast"] --> D["AgentCulture mesh repos"]
A --> E["Wrapper scripts (*.sh)"] --> C
A --> F["Tests (test_think_skill)"] --> G["CI / pytest"]
A --> H["Release metadata (pyproject, CHANGELOG)"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Patch downstream copies directly
  • ➕ Immediate fix in specific repos without waiting for broadcast tooling
  • ➕ Can be targeted to only affected downstream consumers
  • ➖ Doesn’t address the origin source-of-truth; drift will recur on next re-pull
  • ➖ High coordination cost across many repos (manual, error-prone)
2. Add CI guardrail to prevent future stale provenance text
  • ➕ Prevents reintroducing steward/provenance drift (cheap, automated)
  • ➕ Keeps broadcast text consistent with current mesh roles
  • ➖ Requires agreeing on the exact invariants to assert (strings vs structured metadata)
  • ➖ Adds a small amount of ongoing CI maintenance

Recommendation: The PR’s approach (fix at origin + patch release) is the right strategy because guildmaster/rollout propagation is explicitly the scaling mechanism. Consider a small follow-up CI check (e.g., grep/assertions for Origin header supplier + provenance phrasing) to stop similar drift from silently rebroadcasting.

Files changed (11) +22 / -12

Tests (1) +1 / -1
test_think_skill.pyUpdate contract docstring supplier: steward → guildmaster +1/-1

Update contract docstring supplier: steward → guildmaster

• Fixes the test module’s docstring to name guildmaster as the pulling/broadcasting mesh supplier. Keeps the documented contract aligned with current mesh topology.

tests/test_think_skill.py

Documentation (9) +20 / -10
SKILL.mdClarify vendoring wording to reference inbound skills +1/-1

Clarify vendoring wording to reference inbound skills

• Rewords provenance text from “other skills” to “inbound skills” to accurately describe which skills are not vendored from guildmaster. Keeps the description consistent with the skill family terminology.

.claude/skills/assign-to-workforce/SKILL.md

assign-to-workforce.shUpdate Origin header supplier: steward → guildmaster +1/-1

Update Origin header supplier: steward → guildmaster

• Fixes the Origin header comment to name guildmaster as the current mesh supplier. Prevents stale provenance text from being rebroadcast verbatim downstream.

.claude/skills/assign-to-workforce/scripts/assign-to-workforce.sh

SKILL.mdClarify vendoring wording to reference inbound skills +1/-1

Clarify vendoring wording to reference inbound skills

• Replaces “other skills” with “inbound skills” in the description of vendoring behavior. Aligns terminology across origin skills.

.claude/skills/deviate/SKILL.md

SKILL.mdRefresh provenance: authoring order vs flow order and upstream clause +5/-3

Refresh provenance: authoring order vs flow order and upstream clause

• Clarifies that “fourth” refers to authoring order while 'scope' is the opening leg of the workflow. Adds the explicit “never re-vendored back” clause to match sibling skills’ upstream semantics.

.claude/skills/scope/SKILL.md

SKILL.mdClarify vendoring wording to reference inbound skills +1/-1

Clarify vendoring wording to reference inbound skills

• Updates the non-vendored phrasing to “inbound skills” for accuracy and consistency with the skill taxonomy. No behavioral changes.

.claude/skills/spec-to-plan/SKILL.md

spec-to-plan.shUpdate Origin header supplier: steward → guildmaster +1/-1

Update Origin header supplier: steward → guildmaster

• Adjusts the Origin comment to reflect the post-cutover mesh supplier name (guildmaster). Ensures downstream broadcast copies carry correct provenance text.

.claude/skills/spec-to-plan/scripts/spec-to-plan.sh

SKILL.mdClarify vendoring wording to reference inbound skills +1/-1

Clarify vendoring wording to reference inbound skills

• Rewords provenance text to say the skill is not vendored like the inbound skills, replacing the ambiguous “other skills” phrasing. Improves consistency across the origin-skill set.

.claude/skills/think/SKILL.md

think.shUpdate Origin header supplier: steward → guildmaster +1/-1

Update Origin header supplier: steward → guildmaster

• Updates the script’s Origin header to name guildmaster as the mesh supplier. Avoids broadcasting stale role names to downstream repos.

.claude/skills/think/scripts/think.sh

CHANGELOG.mdAdd 0.18.1 Fixed entry describing provenance text corrections +8/-0

Add 0.18.1 Fixed entry describing provenance text corrections

• Introduces a 0.18.1 section dated 2026-07-15 with three Fixed bullets covering the supplier rename, wording precision, and 'scope' provenance clarification. Documents the reason for the patch release and links it to #74.

CHANGELOG.md

Other (1) +1 / -1
pyproject.tomlBump project version to 0.18.1 +1/-1

Bump project version to 0.18.1

• Increments the package version from 0.18.0 to 0.18.1 to ship the provenance-text fixes as a patch release. No dependency or build setting changes.

pyproject.toml

@OriNachum
OriNachum merged commit a19819f into main Jul 15, 2026
8 checks passed
@OriNachum
OriNachum deleted the fix/74-skill-family-nits branch July 15, 2026 06:05
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Land the intended fix to the devague skill family at source (unblocks rollout-cli's paused mesh broadcast — 24 PRs open, 46 pending)

1 participant