Skip to content

fix(browser): serialize undefined run results as null #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rishabhraj36 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

fix(browser): serialize undefined run results as null #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7fba2f
fix(browser): serialize undefined run results as null
rishabhraj36 Aug 11, 2026
6d1f6c6
test(browser): cover undefined run results
rishabhraj36 Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/browser/run/runner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,14 @@ describe('runBrowserProgram', () => {
expect(output.result).toBe('undefined');
});

it('serializes a program with no explicit return as null', async () => {
const output = await run(`
await page.getByRole('button', { name: 'Save' }).click();
`);

expect(output.result).toBeNull();
});

it('keeps time, memory, output, redaction, and serialization limits', async () => {
await expect(run('while (true) {}', { timeoutMs: 25 })).rejects.toMatchObject({
code: 'BROWSER_RUN_TIMEOUT',
Expand Down
2 changes: 1 addition & 1 deletion src/browser/run/runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ export async function runBrowserProgram(
rejectRun = undefined;
}
try {
const serialized = JSON.stringify(value);
const serialized = JSON.stringify(value === undefined ? null : value);
if (serialized === undefined) throw new TypeError('Result is not JSON serializable.');
return serialized;
} catch (cause) {
Expand Down