fix: tokenize plugin search queries so multi-word terms match - #288
Open
ayushsingh82 wants to merge 1 commit into
Open
fix: tokenize plugin search queries so multi-word terms match#288ayushsingh82 wants to merge 1 commit into
ayushsingh82 wants to merge 1 commit into
Conversation
searchCatalogPlugins tested the query as one literal substring, so "hacker news" missed the hackernews plugin even though "hackernews" and "hacker" alone both matched. Split the query into tokens, strip non-alphanumerics from tokens and haystack, and require every token to match — so "hacker news", "hacker-news", and "hackernews" all hit. Fixes agentrhq#282
Contributor
🟢 No documentation gap found — medium confidenceThe automated review found no documentation gap in the supplied changes. This review is advisory and does not block merging. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
searchCatalogPluginsmatched the query as one literal substring, so a multi-word query likehacker newsmissed thehackernewsplugin even thoughhackernewsandhackeralone both matched.hacker news,hacker-news, andhackernewsall hit.Fixes #282
Test plan
npx tsc --noEmitsrc/plugin-catalog.test.tscovering the exact repro from the issue and confirming multi-token queries still require every token to match; verified they fail against the pre-fix code and pass after.