Skip to content

fix(rag): RAG-retrieved use USER role, AGENTIC RAG mode add missing retrieveConfig#949

Open
guanxuc wants to merge 3 commits intoagentscope-ai:mainfrom
guanxuc:fix-rag-0313
Open

fix(rag): RAG-retrieved use USER role, AGENTIC RAG mode add missing retrieveConfig#949
guanxuc wants to merge 3 commits intoagentscope-ai:mainfrom
guanxuc:fix-rag-0313

Conversation

@guanxuc
Copy link
Contributor

@guanxuc guanxuc commented Mar 13, 2026

AgentScope-Java Version

1.0.11

Description

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@guanxuc guanxuc requested a review from a team March 13, 2026 14:09
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...o/agentscope/core/rag/KnowledgeRetrievalTools.java 25.00% 5 Missing and 1 partial ⚠️
...in/java/io/agentscope/core/rag/GenericRAGHook.java 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@guanxuc
Copy link
Contributor Author

guanxuc commented Mar 13, 2026

The unit test has covered the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]:GenericRAGHook should use user message [Bug]:ReActAgent AGENTIC RAG mode ignores retrieveConfig, causing configuration to be ineffective

1 participant