Skip to content

fix: update examples to use clientStarter and fix BrowserSandbox lazy init #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chickenlj merged 2 commits into from
May 7, 2026
Merged

fix: update examples to use clientStarter and fix BrowserSandbox lazy init #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f6491b
fix: update examples to use clientStarter and fix BrowserSandbox lazy…
flystar32 Apr 27, 2026
9f945c7
Merge branch 'main' into fix/examples-clientconfig-to-clientstarter
flystar32 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ullstack_runtime/backend/src/main/java/io/agentscope/browser/BrowserAgentApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ public InMemoryMemoryService memoryService() {
@Bean
public SandboxService sandboxService() {
logger.info("Creating SandboxService bean");
BaseClientStarter clientConfig = DockerClientStarter.builder().build();
BaseClientStarter clientStarter = DockerClientStarter.builder().build();
ManagerConfig managerConfig = ManagerConfig.builder()
.clientConfig(clientConfig)
.clientStarter(clientStarter)
.build();
SandboxService sandboxService = new SandboxService(managerConfig);
sandboxService.start();
Expand Down
10 changes: 7 additions & 3 deletions .../simple_sandbox_tool_example/src/main/java/com/example/agentscope/config/AgentConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ public DashScopeChatModel chatModel() {
*/
@Bean
public SandboxService sandboxService() {
BaseClientStarter clientConfig = DockerClientStarter.builder().build();
BaseClientStarter clientStarter = DockerClientStarter.builder().build();
ManagerConfig managerConfig = ManagerConfig.builder()
.clientConfig(clientConfig)
.clientStarter(clientStarter)
.build();

SandboxService service = new SandboxService(managerConfig);
Expand All @@ -92,9 +92,13 @@ public Toolkit createToolkit(SandboxService sandboxService) {
try {
BrowserSandbox browserSandbox = new BrowserSandbox(sandboxService, "agent-user", "agent-session");
toolkit.registerTool(ToolkitInit.BrowserNavigateTool(browserSandbox));
// getInfo() triggers lazy initialization (container creation)
// getDesktopUrl() bypasses it, so we must initialize first
browserSandbox.getInfo();
String desktopUrl = browserSandbox.getDesktopUrl();
System.out.println("GUI Desktop URL: " + desktopUrl);
} catch (Exception ignored) {
} catch (Exception exception) {
exception.printStackTrace();
}
return toolkit;
}
Expand Down
9 changes: 6 additions & 3 deletions ...d_sandbox_tool_example/src/main/java/com/example/agentscope/SandboxStructuredExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,21 @@ public class SandboxStructuredExample {

public static void main(String[] args) throws Exception {

BaseClientStarter clientConfig = DockerClientStarter.builder().build();
BaseClientStarter clientStarter = DockerClientStarter.builder().build();
ManagerConfig managerConfig = ManagerConfig.builder()
.clientConfig(clientConfig)
.clientStarter(clientStarter)
.build();

SandboxService service = new SandboxService(managerConfig);
service.start();

Toolkit toolkit = new Toolkit();
try {
BrowserSandbox browserSandbox = new BrowserSandbox(service, "agent-user", "agent-sessopn");
BrowserSandbox browserSandbox = new BrowserSandbox(service, "agent-user", "agent-session");
toolkit.registerTool(ToolkitInit.BrowserNavigateTool(browserSandbox));
// getInfo() triggers lazy initialization (container creation)
// getDesktopUrl() bypasses it, so we must initialize first
browserSandbox.getInfo();
String desktopUrl = browserSandbox.getDesktopUrl();
System.out.println("GUI Desktop URL: " + desktopUrl);
} catch (Exception ignored) {
Expand Down
Loading