docs(m164): sign-in events record the caller's address, not the proxy's - #174
Merged
Merged
Conversation
X-Forwarded-For and Fly-Client-IP were read under capitalised names against httpz's lowercased exact-match lookup, so both returned nothing on every request. Covers the four consequences: the spoofing detector, the session replay fingerprint, the seven audit events, and created_from_address. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changelog entry for the client-IP attribution fix landing in agentsfleet#601.
X-Forwarded-ForandFly-Client-IPwere read under capitalised names. httpz lowercases header names in place while parsing andreq.headeris an exact lookup with no case folding, so both reads returned nothing on every request and the derivation fell through to the raw connection peer.Why it needs an entry
Four user-visible consequences, all on the auth surface:
client_ip_divergentwas false on every event emitted.sha256(address || user-agent || session id)) had a constant address component, so a session presented from elsewhere behind the same proxy fingerprinted identically and was served the cached payload instead of being refused.client_ip_sourcereadingtcp_peerregardless of what the request carried.created_from_addressoncore.cli_credentialsrecorded the proxy, not the operator.Verified wired into production at
session_helpers.zig:45, not test-only.Checks
make lint— exit 0, no broken links**Bold lead-noun**bullets, no marketing words, load-bearing facts kept verbatim, history append-only🤖 Generated with Claude Code
Greptile Summary
Adds an Aug 15, 2026 changelog entry explaining the corrected attribution of sign-in activity to the caller’s address rather than the proxy.
Confidence Score: 5/5
The documentation-only change appears safe to merge.
The new entry follows established changelog syntax, ordering, tags, and terminology, with no concrete build, rendering, or content-consistency failure identified.
Important Files Changed
Reviews (1): Last reviewed commit: "docs(m164): sign-in events record the ca..." | Re-trigger Greptile