fix(boringstack): gate runs generate:api/db:push for the model + surface failed db:push#146
Merged
Merged
Conversation
agjs
force-pushed
the
fix/gate-autoregen-guidance
branch
2 times, most recently
from
July 19, 2026 19:59
01f1d6e to
6ef53b5
Compare
agjs
changed the title
agjs
force-pushed
the
fix/gate-autoregen-guidance
branch
9 times, most recently
from
July 19, 2026 21:33
3d8650f to
ce6e71c
Compare
…(no manual generate:api) The data-fetching guide told the model to manually run `bun run generate:api`, but regenerating the typed client with generate:api is part of the gate (gate.ts FAST_GATE apps/ui leg). That cost the model turns running it by hand and could send it chasing a phantom stale-client cascade. Reworded to only true, gated claims: generate:api is part of the gate (so don't run it by hand or chase client types file-by-file); no 'every cycle' or 'passing gate proves' guarantee (the api-leg && short-circuit + differential suppression make those false in edge cases). Makes NO db:push claim — db:push's exit is currently swallowed (task #60 fixes that), so a green gate can't prove the DB synced. Guidance-only; no gate change.
agjs
force-pushed
the
fix/gate-autoregen-guidance
branch
from
July 19, 2026 21:44
ce6e71c to
e63b957
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two coupled fixes so the
data-fetchingconvention guide is both useful and safe.1. Guidance (the original intent)
The guide told the model to manually run
bun run generate:api. The gate already runs it (+db:push) as part of each gate cycle (gate.tsFAST_GATE apps/ui leg +boringstackCommandStage). Reworded to: the gate runs them for the model (never by hand); a passing gate means client + DB are in sync with the schema; a rename is one gate pass, not a per-file type chase.Why (the 'ask deepseek' directive): asked the builder model what a fresh CRUD build still wastes turns on. Its #1 was a Drizzle→OpenAPI→client type-drift cascade needing a 'single-command schema-sync tool' — verified against the code that this already exists as the auto-gate step, so the ask was confabulated. The real gap was the misleading guidance.
2. Bugfix (surfaced by the panel while reviewing #1)
boringstackCommandStagediscardeddb:push's exit code (gate-stages.ts) — a schema that wouldn't sync left the DB stale while the gate still passed, and the guide says never run db:push by hand, so the model had no signal and no recourse. Now a nonzerodb:pushis a red gate with a model-visible, stably-keyed, actionable error (fix the schema; distinguishes the infra-unreachable case). This makes the guide's on-green claim actually true.Tests
a failed db:push is a RED gate— proves the exit is no longer swallowed.db:pushissued;generate:apiordered before the uicheck).Reviews
Local 4-model panel gated every revision (PASS 4/4); each round's finding addressed — the db:push bug was itself a panel finding, now fixed. No gate relaxation.