Conversation
Signed-off-by: Aron Kerekes <arkereke@cisco.com>
keraron
requested review from
adamtagscherer,
micpapal,
msardara and
ramizpolic
|
|
||
| **Version Resolution:** | ||
|
|
||
| When no version is specified, commands return the most recently created record (by record's `created_at` field). This allows non-semver tags like `latest`, `dev`, or `stable`. |
There was a problem hiding this comment.
nit: if multiple records exist with the same name:version then it throws and error to look by CID
| | `--oidc-token` | - | OIDC token for non-interactive signing (requires `--sign`) | No | - | | ||
| | `--fulcio-url` | - | Sigstore Fulcio URL (requires `--sign`) | No | https://fulcio.sigstore.dev | | ||
| | `--rekor-url` | - | Sigstore Rekor URL (requires `--sign`) | No | https://rekor.sigstore.dev | | ||
| | `--server-addr` | DIRECTORY_CLIENT_SERVER_ADDRESS | DIR server address | No | localhost:8888 | |
There was a problem hiding this comment.
--server-addr is a global flag, I think we shouldn't mention it in every dirctl subcommand, rather have a central place where we display the global flags that are available to all subcommands
| # Returns: bafyreib... | ||
| ``` | ||
|
|
||
| 2. Sign the record (triggers automatic verification). |
There was a problem hiding this comment.
reword: automatic domain name verification
a signed and verified record is not the same as a record that has a name verified attribute
| dirctl sync delete abc123-def456-ghi789 | ||
| git clone https://github.com/agntcy/dir | ||
| cd dir | ||
| task build-dirctl |
There was a problem hiding this comment.
We have no task build-dirctl, we have cli:compile
| export DIRECTORY_CLIENT_SERVER_ADDRESS=localhost:8888 | ||
| dirctl routing list | ||
| ``` | ||
| # Or pull by name (if the record has a verifiable name) |
There was a problem hiding this comment.
It doesn't matter if a record has a verifiable name or not, it can be pulled by name either case.
|
|
||
| **Example Cursor configuration (`~/.cursor/mcp.json`):** | ||
|
|
||
| ```json |
There was a problem hiding this comment.
To start the MCP server we need to set the OASF_API_VALIDATION_SCHEMA_URL env var otherwise it won't start. I propose this to have a default value that points to our schema server, but this is the current situation.
{
"mcpServers": {
"dir-mcp-server": {
"command": "/absolute/path/to/dirctl",
"args": ["mcp", "serve"],
"env": {
"OASF_API_VALIDATION_SCHEMA_URL": "https://schema.oasf.outshift.com"
}
}
}
}| ??? example "Example Cursor configuration (`~/.cursor/mcp.json`)" | ||
|
|
||
| ```json | ||
| { |
There was a problem hiding this comment.
{
"mcpServers": {
"dir-mcp-server": {
"command": "docker",
"args": [
"run",
"--rm",
"-i",
"--env",
"OASF_API_VALIDATION_SCHEMA_URL=https://schema.oasf.outshift.com",
"ghcr.io/agntcy/dir-ctl:latest",
"mcp",
"serve"
]
}
}
}| } | ||
| ``` | ||
|
|
||
| ## Directory MCP Server Tools |
There was a problem hiding this comment.
One tool is missing from here:
https://github.com/agntcy/dir/blob/main/mcp/server/server.go#L218
2 participants
This PR fixes #395 and #406.