fix: normalize Conscrypt EdDSA keys for SSHJ host key verification#868
Merged
Conversation
On Android 13+, SSH servers presenting Ed25519 host keys trigger "Don't know how to encode key: com.android.org.conscrypt.OpenSslEdDsaPublicKey" because SSHJ does not recognize Conscrypt's EdDSA key class. Re-encode unrecognized public keys through BouncyCastle's KeyFactory so SSHJ can handle them. Applied to both TOFU and pinned host key verification paths, and to toSshPublicKey() for key serialization. reverting workaround (9d9eaaa) that fixed sshj failure --------- Co-authored-by: Alexander Grahn <agrahn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android 13+, SSH servers presenting Ed25519 host keys trigger "Don't know how to encode key: com.android.org.conscrypt.OpenSslEdDsaPublicKey" because SSHJ does not recognize Conscrypt's EdDSA key class.
Re-encode unrecognized public keys through BouncyCastle's KeyFactory so SSHJ can handle them. Applied to both TOFU and pinned host key verification paths, and to toSshPublicKey() for key serialization.
reverting workaround (9d9eaaa) that fixed sshj failure
Applies PR #865 with modifications and may therefore close #865.