Bump napi-derive from 3.6.2 to 3.6.3 in /native/aa-ffi-node - #366
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Bumps [napi-derive](https://github.com/napi-rs/napi-rs) from 3.6.2 to 3.6.3. - [Release notes](https://github.com/napi-rs/napi-rs/releases) - [Commits](napi-rs/napi-rs@napi-derive-v3.6.2...napi-derive-v3.6.3) --- updated-dependencies: - dependency-name: napi-derive dependency-version: 3.6.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
2d21088 to
493c5f8
Compare
Chisanan232
left a comment
There was a problem hiding this comment.
Now green after #367 landed. Approving.
Why this PR failed on its own: napi-derive 3.6.3's #[napi] macro expands to references to NativeBorrowScope, NativeBorrowBarrier and register_native_borrow_with_value in napi::bindgen_prelude. None of those exist in napi 3.12.0, so napi-build (ubuntu-latest, 20) and (ubuntu-latest, 22) died with 11 E0433/E0425 errors out of src/lib.rs. The napi family has to move together, so #367 (napi 3.12.1) had to land first — it did, as 65e9da75.
Verification, not just green CI: I merged main into this branch locally, confirmed cargo metadata --locked and then ran a real cargo build --lib --locked — compiles clean in 24s, all 11 errors gone. Dependabot then rebased the branch itself; I diffed its resulting Cargo.lock against my locally compiled one and they are byte-identical, so its rebase is trustworthy here.
Final resolved family: napi 3.12.1, napi-build 2.4.1, napi-derive 3.6.3, napi-derive-backend 6.1.2. The napi-derive-backend move is napi-derive's own dependency co-resolving, not scope creep. Net diff vs main is 4 lines of lockfile.
Note #368 (napi-build 2.4.0 → 2.4.1) is now redundant: #367 already carried napi-build 2.4.1 as part of cargo's co-resolution, so main is already at 2.4.1.
Bumps napi-derive from 3.6.2 to 3.6.3.
Release notes
Sourced from napi-derive's releases.
Commits
956e452chore: release (#3448)73048f5chore(release): publish61fae8afix(napi): stop unloading addons with live native code, preserve non-Error re...93e86cechore(release): publish2c90599fix(cli): support npm 12 pack output (#3449)360b1ecfix(wasi): avoid randomness during module registration (#3447)b648c40build(deps): bump nanoid from 3.3.16 to 3.3.18 (#3446)ffda4efchore(deps): update dependency js-yaml to v4.3.1 [security] (#3445)387b0dcfeat(cli): size WASI browser worker pools from navigator.hardwareConcurrency ...61e4346build(deps): bump fast-uri from 3.1.4 to 3.1.5 (#3440)