Skip to content

fix(x402): classify transaction_held as TRANSACTION_PENDING (closes #93) #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tfireubs-ui wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix(x402): classify transaction_held as TRANSACTION_PENDING (closes #93) #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/middleware/x402.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,13 @@ function classifyPaymentError(error: unknown, settleResult?: Partial<SettlementR
return { code: X402_ERROR_CODES.TRANSACTION_PENDING, message: "Transaction pending in settlement relay, please retry", httpStatus: 402, retryAfter: 10 };
}

// Relay nonce queue: transaction held due to a sender nonce gap. The relay accepted
// the tx but can't dispatch it until the gap is filled. Treat as retryable TRANSACTION_PENDING
// with a longer backoff — the gap may take 30+ seconds to resolve.
if (combined.includes("transaction_held") || combined.includes("transaction held")) {
return { code: X402_ERROR_CODES.TRANSACTION_PENDING, message: "Transaction held in relay nonce queue, please retry", httpStatus: 402, retryAfter: 30 };
}

if (combined.includes("sender_mismatch") || combined.includes("sender mismatch")) {
return { code: X402_ERROR_CODES.SENDER_MISMATCH, message: "Payment sender does not match expected address", httpStatus: 400 };
}
Expand Down