Skip to content

🎨 Palette: [UX improvement] Add comma formatting to scores and enhance achievement feedback#319

Open
aidasofialily-cmd wants to merge 1 commit into
mainfrom
palette-score-formatting-15976917118235747829
Open

🎨 Palette: [UX improvement] Add comma formatting to scores and enhance achievement feedback#319
aidasofialily-cmd wants to merge 1 commit into
mainfrom
palette-score-formatting-15976917118235747829

Conversation

@aidasofialily-cmd

Copy link
Copy Markdown
Owner

💡 What: The UX enhancement added

This PR introduces thousand separators (commas) to all numeric displays in the Speed Clicker game and enhances the "New Best" achievement feedback.

🎯 Why: The user problem it solves

Large numbers in clicker games are difficult to read at a glance. Adding commas makes scores like 1234567 much easier to parse as 1,234,567. Additionally, showing the previous high score during a record-breaking run provides better context for the player's achievement.

♿ Accessibility: Any a11y improvements made

  • Improved cognitive ease by grouping digits, making large numbers more accessible to users with dyscalculia or general reading difficulties in fast-paced environments.
  • Added visual and contextual clarity to state changes (new high score).

🛠️ Technical Details

  • Added a robust formatWithCommas helper function in C++.
  • Verified logic with a standalone test suite covering edge cases (zero, negative, large numbers).
  • Maintained consistent terminal formatting and ensured no regressions in UX standards (cursor handling, etc.).

PR created automatically by Jules for task 15976917118235747829 started by @aidasofialily-cmd

…e achievement feedback

- Implement `formatWithCommas` helper to improve readability of large scores.
- Apply thousands separators to live score, high score, and final results.
- Enhance 'NEW BEST!' message with previous high score context and visual flair.
- Update palette.md with learnings on CLI numeric readability and contextual feedback.

Co-authored-by: aidasofialily-cmd <247843425+aidasofialily-cmd@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant