Skip to content

🎨 Palette: Implement comma formatting for scores#323

Open
aidasofialily-cmd wants to merge 1 commit into
mainfrom
palette/comma-formatting-scores-17125428020385777333
Open

🎨 Palette: Implement comma formatting for scores#323
aidasofialily-cmd wants to merge 1 commit into
mainfrom
palette/comma-formatting-scores-17125428020385777333

Conversation

@aidasofialily-cmd

Copy link
Copy Markdown
Owner

💡 What: This PR introduces thousand-separator formatting (commas) for scores in the Speed Clicker game. It also enhances the achievement feedback by displaying the previous personal best when a new record is set.

🎯 Why: As scores in clicker games grow rapidly, raw integers become difficult to read at a glance. Comma formatting (e.g., "1,000,000") provides immediate clarity. Including the previous high score in the "NEW BEST!" message adds meaningful context to the achievement.

♿ Accessibility: Improved readability for all users, particularly those who process grouped numbers more easily.

📸 Changes:

  • Score: 1000 -> Score: 1,000
  • NEW BEST! 🥳 -> NEW BEST! 🥳 (was 900)

PR created automatically by Jules for task 17125428020385777333 started by @aidasofialily-cmd

- Added `formatWithCommas` utility in `src/utils.hpp`.
- Applied comma formatting to all score displays in `src/main.cpp`.
- Enhanced "NEW BEST!" message to include previous high score context.
- Added UX learning entry to `.Jules/palette.md`.

Co-authored-by: aidasofialily-cmd <247843425+aidasofialily-cmd@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant