Skip to content

🎨 Palette: Add score formatting and contextual achievement feedback#341

Open
aidasofialily-cmd wants to merge 1 commit into
mainfrom
palette-score-formatting-17047169077127159270
Open

🎨 Palette: Add score formatting and contextual achievement feedback#341
aidasofialily-cmd wants to merge 1 commit into
mainfrom
palette-score-formatting-17047169077127159270

Conversation

@aidasofialily-cmd

Copy link
Copy Markdown
Owner

💡 What: The UX enhancement added

This PR introduces thousand-separator formatting for all numeric scores (e.g., "1,234,567" instead of "1234567") and enhances the "NEW BEST!" achievement notification to include the previous personal best for immediate context.

🎯 Why: The user problem it solves

Large numbers are difficult to read at a glance in a fast-paced clicker game. Providing comma separators significantly improves readability. Additionally, seeing the "was X" context when breaking a record makes the achievement feel more impactful and informative.

♿ Accessibility: Any a11y improvements made

  • Improved readability of large numbers for all users.
  • Added color highlighting (CLR_CTRL - Bold Yellow) to the achievement message to make it more prominent and easier to distinguish from other UI elements.

PR created automatically by Jules for task 17047169077127159270 started by @aidasofialily-cmd

Implemented thousand-separator formatting for scores and enhanced the "NEW BEST!" notification with context and color to improve readability and delight.

- Added `src/utils.hpp` with `formatWithCommas` utility.
- Updated all score displays in `src/main.cpp` to use comma formatting.
- Enhanced achievement feedback to show the previous high score.
- Verified UX compliance with `verify_ux.py`.

Co-authored-by: aidasofialily-cmd <247843425+aidasofialily-cmd@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant