-
Notifications
You must be signed in to change notification settings - Fork 20
Fix broken imports and deprecated API usage that caused CI failures #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,23 @@ | |
| import inspect | ||
| import logging | ||
| import re | ||
| import six | ||
| from typing import ( | ||
| Any, | ||
| Callable, | ||
| Dict, | ||
| Hashable, | ||
| List, | ||
| Mapping, | ||
| MutableSequence, | ||
| Optional, | ||
| Sequence, | ||
| Tuple, | ||
| Type, | ||
| Union, | ||
| cast, | ||
| ) | ||
|
|
||
| import kiwipy | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. how come this magically appeared here :)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. perhaps it's just due to reordering the commits. never mind
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, Isee. it's imported only for typing:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Plumpy depends on kiwipy in other modules anyways.. So I think this will not add extra overheads.. So it should be fine |
||
|
|
||
| from . import lang, mixins, persistence, process_states, processes | ||
| from .utils import PID_TYPE, SAVED_STATE_TYPE | ||
|
|
@@ -248,7 +264,7 @@ def __str__(self) -> str: | |
| class _FunctionCall(_Instruction): | ||
| def __init__(self, func: WC_COMMAND_TYPE) -> None: | ||
| try: | ||
| args = inspect.getargspec(func)[0] | ||
| args = inspect.getfullargspec(func)[0] | ||
| except TypeError: | ||
| raise TypeError(f'func is not a function, got {type(func)}') | ||
| if len(args) != 1: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this could be actually followed. By a pre-commit. But not a most..