Migrated the project instructions into Intelligence rules and skills, and excluded the generated layer from the VSIX - #36
Conversation
… and excluded the generated layer from the VSIX
There was a problem hiding this comment.
Pull request overview
Migrates the repository’s AI guidance from the legacy CLAUDE.md + tracked .claude/skills/ into the Intelligence rules/skills layer (with generated AGENTS.md output), and updates VS Code extension packaging ignores so generated tooling content doesn’t ship in the VSIX.
Changes:
- Added project-owned Intelligence rules/skills plus
intelligence.yaml+intelligence.lock, and regeneratedAGENTS.mdas the tool-neutral entrypoint. - Removed legacy
CLAUDE.mdand the tracked.claude/skills/*content that was superseded by Intelligence packages + project profile. - Tightened
.vscodeignore/.gitignoreto keep Intelligence sources/output and other generated tooling artifacts out of Marketplace releases; updated in-repo references fromCLAUDE.md→AGENTS.md.
Reviewed changes
Copilot reviewed 23 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/log.ts |
Updates an internal header comment reference from CLAUDE.md to AGENTS.md. |
intelligence/skills/vscode-run-local/SKILL.md |
Renames and refreshes the local manual acceptance skill for running the extension in VS Code. |
intelligence/skills/vscode-publish-marketplace/SKILL.md |
Adds an owner-invoked Marketplace publish procedure, including pre-upload gates and VSIX content checks. |
intelligence/skills/spec-implement/SKILL.md |
Adds the “implement a spec” workflow skill aligned to the repo’s documentation model and verify gate. |
intelligence/skills/spec-draft/SKILL.md |
Adds the “draft the next spec” workflow skill matching the repo’s numbered spec convention. |
intelligence/rules/sandbox-console.md |
Adds the always-on project rule capturing product/UX invariants and sbx lifecycle facts. |
intelligence/rules/sandbox-console-src.md |
Adds scoped rule for src/** + package.json covering module boundaries, CLI containment, and credential model. |
intelligence/rules/dev-project-profile.md |
Adds the pinned project profile used by shared dev/git rules and skills (verify gate, branching, PR/release policy). |
intelligence.yaml |
Introduces the Intelligence manifest (sources + targets for AGENTS.md, .claude, .cursor). |
intelligence.lock |
Pins Intelligence engine/package versions and resolved SHAs for reproducible sync output. |
CONTRIBUTING.md |
Updates contributor guidance to point at AGENTS.md as the canonical AI onboarding surface. |
CLAUDE.md |
Removes the legacy Claude-specific instruction file (content now lives in Intelligence rules/skills). |
AGENTS.md |
Replaces the placeholder with generated, inlined rules + catalog of available agents/skills/rules. |
.vscodeignore |
Expands ignores to exclude Intelligence sources/output and other dev-only artifacts from the packaged VSIX. |
.sandbox/config.yaml |
Updates a comment to reflect the vscode-run-local skill rename. |
.gitignore |
Stops tracking generated tooling output/state (.intelligence/, .claude/*, .cursor/*, etc.) and keeps backups ignored. |
.github/PULL_REQUEST_TEMPLATE.md |
Updates the template comment to reference AGENTS.md instead of CLAUDE.md. |
.claude/skills/spec-new-iteration/SKILL.md |
Removes legacy tracked Claude skill (superseded by Intelligence spec-draft). |
.claude/skills/spec-implement/SKILL.md |
Removes legacy tracked Claude skill (superseded by Intelligence spec-implement). |
.claude/skills/git-open-pr/SKILL.md |
Removes legacy tracked Claude skill (superseded by packaged git-open-pr). |
.claude/skills/git-merge-pr/SKILL.md |
Removes legacy tracked Claude skill (superseded by packaged git-merge-pr). |
.claude/skills/git-commit-push/SKILL.md |
Removes legacy tracked Claude skill (superseded by packaged git-commit-push). |
.claude/skills/ext-release/SKILL.md |
Removes legacy tracked release skill (replaced by vscode-publish-marketplace + packaged git-create-release). |
.claude/skills/dev-review-changes/SKILL.md |
Removes legacy tracked review skill (superseded by packaged dev-review-changes). |
.claude/skills/dev-onboard/SKILL.md |
Removes legacy tracked onboarding skill (superseded by Intelligence + generated AGENTS.md). |
Suppressed comments (1)
intelligence/skills/vscode-run-local/SKILL.md:58
- The text "never
- \|block scalars" reads like a literal YAML syntax (including the backslash), which is not valid YAML and could confuse readers; the intent seems to be forbidding YAML multi-line block scalars in general. Reword to avoid introducing a backslash into the depicted syntax while keeping the Markdown table intact.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…epicting escaped syntax
|
The suppressed review comment on The The fix names the construct instead of depicting it — "plain and quoted YAML scalars only, never block scalars". That reads correctly rendered and raw, and needs no escape, so the table stays intact. |
Risk & Size
Risk: Low
Size: Large
What & Why
The repository's AI instructions move from a hand-maintained
CLAUDE.mdplus nine.claude/skills/files onto the Intelligence layer, so one tool-neutral source feeds Claude, Cursor andAGENTS.mdinstead of three copies drifting apart.intelligence inithad already run before this branch: its first sync overwrote the tracked.claude/output and left the original instructions only in the gitignoredintelligence/_backup/, withAGENTS.mdcarrying an "onboarding is pending" banner. This PR completes that migration and removes the transitional state.While verifying the result,
npx vsce lsreported the packaged extension had grown from 7 files to 87.vscestops reading.gitignoreas soon as.vscodeignoreexists, so everythinginitadded — the manifest, the lock, the package store, the backup of the old instructions and the generated Cursor output — would have shipped to the Marketplace on the next release, where versions are write-once..vscodeignoreis fixed here and the list is back to 7.No FR is touched. Process changes carry no
docs/specs/00Nentry by the project's own rule: specs record product changes only.Changes
intelligence/rules/):sandbox-console.md(always-on — documentation model, the load-bearing sbx facts, UX invariants);sandbox-console-src.md(scoped tosrc/**— module map and dependency direction, sbx CLI containment, credential model);dev-project-profile.md(pins verify, branching, PR and release policy so the installed shared skills behave as this repository already does).intelligence/skills/):spec-draft,spec-implement,vscode-run-local,vscode-publish-marketplace. The formerdev-onboard,dev-review-changes,git-commit-push,git-open-prandgit-merge-prare dropped — the installed packages plus the profile cover them.vscode-publish-marketplacekeeps only what is specific to the Marketplace and delegates branch, PR, tag and release object togit-create-release.CLAUDE.mdremoved; its content lives in the twosandbox-consolerules. Generated.claude/output is no longer tracked..vscodeignore: excludes the Intelligence sources, package store, manifest, lock and generated Cursor output.CLAUDE.mdreferences updated inCONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.mdandsrc/log.ts(comment only). The.sandbox/config.yamlcomment follows thevscode-run-localrename.intelligence/_backup/stays in place and gitignored until its removal is approved separately.How to Verify
npm run verify— exits 0.npx vsce ls— exactly seven entries:THIRD_PARTY_NOTICES.txt,README.md,package.json,LICENSE,CHANGELOG.md,media/icon.png,dist/extension.js. This is the line worth real review attention, because it governs what reaches the Marketplace.intelligence status --check— reportsall good.intelligence sync— reportsIS_STATUS=ok. One warning is expected and correct to ignore:NOT SYNCED: intelligence/_backup/.claude/skills. The backup is deliberately not a source, and the warning's advice to add it undersources:would re-inject the very skills this PR migrated away from.AGENTS.mdopens with the project header and no "onboarding is pending" banner; always-on rules are inlined andsandbox-console-srcis listed as scoped.src/edit is a comment insrc/log.ts.Reviewer note:
.vscodeignorematches no glob in the new profile'spr_risk_globs, so the mechanical Risk lands on Low even though that file governs the published artifact. Adding it to the medium globs is a sensible follow-up, kept out of this PR to avoid widening it.