Skip to content

Migrated the project instructions into Intelligence rules and skills, and excluded the generated layer from the VSIX - #36

Merged
dzykovic merged 2 commits into
mainfrom
feature/intelligence-onboarding
Aug 28, 2026
Merged

dzykovic merged 2 commits into
mainfrom
feature/intelligence-onboarding

Conversation

@dzykovic

Copy link
Copy Markdown
Contributor

Risk & Size

Risk: Low
Size: Large

What & Why

The repository's AI instructions move from a hand-maintained CLAUDE.md plus nine .claude/skills/ files onto the Intelligence layer, so one tool-neutral source feeds Claude, Cursor and AGENTS.md instead of three copies drifting apart.

intelligence init had already run before this branch: its first sync overwrote the tracked .claude/ output and left the original instructions only in the gitignored intelligence/_backup/, with AGENTS.md carrying an "onboarding is pending" banner. This PR completes that migration and removes the transitional state.

While verifying the result, npx vsce ls reported the packaged extension had grown from 7 files to 87. vsce stops reading .gitignore as soon as .vscodeignore exists, so everything init added — the manifest, the lock, the package store, the backup of the old instructions and the generated Cursor output — would have shipped to the Marketplace on the next release, where versions are write-once. .vscodeignore is fixed here and the list is back to 7.

No FR is touched. Process changes carry no docs/specs/00N entry by the project's own rule: specs record product changes only.

Changes

  • Rules (intelligence/rules/): sandbox-console.md (always-on — documentation model, the load-bearing sbx facts, UX invariants); sandbox-console-src.md (scoped to src/** — module map and dependency direction, sbx CLI containment, credential model); dev-project-profile.md (pins verify, branching, PR and release policy so the installed shared skills behave as this repository already does).
  • Skills (intelligence/skills/): spec-draft, spec-implement, vscode-run-local, vscode-publish-marketplace. The former dev-onboard, dev-review-changes, git-commit-push, git-open-pr and git-merge-pr are dropped — the installed packages plus the profile cover them. vscode-publish-marketplace keeps only what is specific to the Marketplace and delegates branch, PR, tag and release object to git-create-release.
  • CLAUDE.md removed; its content lives in the two sandbox-console rules. Generated .claude/ output is no longer tracked.
  • .vscodeignore: excludes the Intelligence sources, package store, manifest, lock and generated Cursor output.
  • Stale CLAUDE.md references updated in CONTRIBUTING.md, .github/PULL_REQUEST_TEMPLATE.md and src/log.ts (comment only). The .sandbox/config.yaml comment follows the vscode-run-local rename.
  • intelligence/_backup/ stays in place and gitignored until its removal is approved separately.

How to Verify

  1. npm run verify — exits 0.
  2. npx vsce ls — exactly seven entries: THIRD_PARTY_NOTICES.txt, README.md, package.json, LICENSE, CHANGELOG.md, media/icon.png, dist/extension.js. This is the line worth real review attention, because it governs what reaches the Marketplace.
  3. intelligence status --check — reports all good. intelligence sync — reports IS_STATUS=ok. One warning is expected and correct to ignore: NOT SYNCED: intelligence/_backup/.claude/skills. The backup is deliberately not a source, and the warning's advice to add it under sources: would re-inject the very skills this PR migrated away from.
  4. AGENTS.md opens with the project header and no "onboarding is pending" banner; always-on rules are inlined and sandbox-console-src is listed as scoped.
  5. Behaviour: none to check. No extension code path changed — the only src/ edit is a comment in src/log.ts.

Reviewer note: .vscodeignore matches no glob in the new profile's pr_risk_globs, so the mechanical Risk lands on Low even though that file governs the published artifact. Adding it to the medium globs is a sensible follow-up, kept out of this PR to avoid widening it.

… and excluded the generated layer from the VSIX
Copilot AI lite review requested due to automatic review settings August 28, 2026 12:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the repository’s AI guidance from the legacy CLAUDE.md + tracked .claude/skills/ into the Intelligence rules/skills layer (with generated AGENTS.md output), and updates VS Code extension packaging ignores so generated tooling content doesn’t ship in the VSIX.

Changes:

  • Added project-owned Intelligence rules/skills plus intelligence.yaml + intelligence.lock, and regenerated AGENTS.md as the tool-neutral entrypoint.
  • Removed legacy CLAUDE.md and the tracked .claude/skills/* content that was superseded by Intelligence packages + project profile.
  • Tightened .vscodeignore / .gitignore to keep Intelligence sources/output and other generated tooling artifacts out of Marketplace releases; updated in-repo references from CLAUDE.md → AGENTS.md.

Reviewed changes

Copilot reviewed 23 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/log.ts Updates an internal header comment reference from CLAUDE.md to AGENTS.md.
intelligence/skills/vscode-run-local/SKILL.md Renames and refreshes the local manual acceptance skill for running the extension in VS Code.
intelligence/skills/vscode-publish-marketplace/SKILL.md Adds an owner-invoked Marketplace publish procedure, including pre-upload gates and VSIX content checks.
intelligence/skills/spec-implement/SKILL.md Adds the “implement a spec” workflow skill aligned to the repo’s documentation model and verify gate.
intelligence/skills/spec-draft/SKILL.md Adds the “draft the next spec” workflow skill matching the repo’s numbered spec convention.
intelligence/rules/sandbox-console.md Adds the always-on project rule capturing product/UX invariants and sbx lifecycle facts.
intelligence/rules/sandbox-console-src.md Adds scoped rule for src/** + package.json covering module boundaries, CLI containment, and credential model.
intelligence/rules/dev-project-profile.md Adds the pinned project profile used by shared dev/git rules and skills (verify gate, branching, PR/release policy).
intelligence.yaml Introduces the Intelligence manifest (sources + targets for AGENTS.md, .claude, .cursor).
intelligence.lock Pins Intelligence engine/package versions and resolved SHAs for reproducible sync output.
CONTRIBUTING.md Updates contributor guidance to point at AGENTS.md as the canonical AI onboarding surface.
CLAUDE.md Removes the legacy Claude-specific instruction file (content now lives in Intelligence rules/skills).
AGENTS.md Replaces the placeholder with generated, inlined rules + catalog of available agents/skills/rules.
.vscodeignore Expands ignores to exclude Intelligence sources/output and other dev-only artifacts from the packaged VSIX.
.sandbox/config.yaml Updates a comment to reflect the vscode-run-local skill rename.
.gitignore Stops tracking generated tooling output/state (.intelligence/, .claude/*, .cursor/*, etc.) and keeps backups ignored.
.github/PULL_REQUEST_TEMPLATE.md Updates the template comment to reference AGENTS.md instead of CLAUDE.md.
.claude/skills/spec-new-iteration/SKILL.md Removes legacy tracked Claude skill (superseded by Intelligence spec-draft).
.claude/skills/spec-implement/SKILL.md Removes legacy tracked Claude skill (superseded by Intelligence spec-implement).
.claude/skills/git-open-pr/SKILL.md Removes legacy tracked Claude skill (superseded by packaged git-open-pr).
.claude/skills/git-merge-pr/SKILL.md Removes legacy tracked Claude skill (superseded by packaged git-merge-pr).
.claude/skills/git-commit-push/SKILL.md Removes legacy tracked Claude skill (superseded by packaged git-commit-push).
.claude/skills/ext-release/SKILL.md Removes legacy tracked release skill (replaced by vscode-publish-marketplace + packaged git-create-release).
.claude/skills/dev-review-changes/SKILL.md Removes legacy tracked review skill (superseded by packaged dev-review-changes).
.claude/skills/dev-onboard/SKILL.md Removes legacy tracked onboarding skill (superseded by Intelligence + generated AGENTS.md).
Suppressed comments (1)

intelligence/skills/vscode-run-local/SKILL.md:58

  • The text "never - \| block scalars" reads like a literal YAML syntax (including the backslash), which is not valid YAML and could confuse readers; the intent seems to be forbidding YAML multi-line block scalars in general. Reword to avoid introducing a backslash into the depicted syntax while keeping the Markdown table intact.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dzykovic

Copy link
Copy Markdown
Contributor Author

The suppressed review comment on intelligence/skills/vscode-run-local/SKILL.md:58 was correct, and it is fixed in 82af24b.

The \| was a Markdown table escape: GitHub renders it back to |, so anyone reading the rendered skill saw the intended - |. The gap is that skills are also consumed as raw Markdown by the agents that execute them, and in raw form the line depicted - \|, which is not YAML syntax at all.

The fix names the construct instead of depicting it — "plain and quoted YAML scalars only, never block scalars". That reads correctly rendered and raw, and needs no escape, so the table stays intact.

@dzykovic
dzykovic merged commit 26952e9 into main Aug 28, 2026
1 check passed
@dzykovic
dzykovic deleted the feature/intelligence-onboarding branch August 28, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants