-
Notifications
You must be signed in to change notification settings - Fork 0
Refine part implementation #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RandVid
wants to merge
3
commits into
main
Choose a base branch
from
refine_part_implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Tests] Missing test for
get_some_cycle_from_sccget_some_cycle_from_sccwas added but no corresponding test was found. There is no test file forconflict_resolving.pyanywhere in the repository.Suggested test cases:
Happy path — simple cycle: Build a graph with a 3-node SCC (A→B→C→A). Call
get_some_cycle_from_scc(["A","B","C"])and assert the returned list forms a valid cycle (each node leads to the next ingood_graph_1).Single-node SCC with self-loop: Create a graph where node "X" has an edge to itself. Pass
scc=["X"]and assert the result is["X"].Single-node SCC without self-loop: Create a graph where node "X" has no self-loop. Pass
scc=["X"]and assert the result is[](empty list — no cycle found).Edge case — larger SCC with multiple possible cycles: Build a graph with 5 nodes and several edges forming multiple cycles. Assert the returned list is non-empty and forms a valid cycle within the SCC.
Error case — empty SCC list: Pass
scc=[]and verify the behavior (currentlydfs(scc[0])would raiseIndexError). Consider whether this should be handled gracefully or documented as a precondition.