-
Notifications
You must be signed in to change notification settings - Fork 0
A bunch of bugfixes and updates for upgrading TanStack Start #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reverts commit a47e5dc.
8090a52 to
9336195
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Upgrade TanStack Start/Router and integrate Nitro v2, plus related refactors from Option-based schemas to nullable values and build/deploy flow updates
- Migrate server routes to createFileRoute with server.handlers and update server utilities (inputValidator, getRequest)
- Switch build output from .output to dist and integrate @tanstack/nitro-v2-vite-plugin; add @vitejs/plugin-react
- Clean up Effect Option usage to nullable, fix CSS variable typo, and update DateFormat API
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Adds Nitro v2 and React Vite plugins; updates plugin stack for Start/Nitro integration |
| src/styles/main.css | Removes invalid sticky rule and adjusts truncate utility |
| src/schemas/post.ts | Replaces Option-based optional fields with nullable and updates validations |
| src/schemas/common.ts | Updates optional date schema to nullable |
| src/routes/sitemap[.]xml.ts | Migrates to createFileRoute server handlers and updates sitemap config |
| src/routes/oembed.$embedId.ts | Migrates to createFileRoute server handlers for oEmbed endpoint |
| src/routes/feeds.default[.]xml.ts | Updates Option usage to nullish and server handlers |
| src/routes/_blog/posts.$lang.$slug.tsx | Removes Option usage and adapts DateFormat/metadata |
| src/routes/__root.tsx | Updates server utilities and font link handling |
| src/router.tsx | Renames router factory to getRouter and removes old Register augmentation |
| src/routeTree.gen.ts | Regenerates tree for file routes; adds react-start Register typing and removes server tree |
| src/dev/post-pipeline.ts | Fixes sort comparator to use Option.fromNullable for optional dates |
| src/components/layout/layout.module.css | Fixes CSS variable name typo |
| src/components/inline/DateFormat.tsx | Simplifies API to nullable date |
| src/components/inline/DateFormat.stories.tsx | Updates stories to new DateFormat API |
| src/components/block/OembedFrame.tsx | Simplifies iframe title text (removes Date.now) |
| src/collections/posts/list/client.ts | Switches to inputValidator for server fn |
| src/collections/posts/item/client.ts | Switches to inputValidator for server fn |
| src/collections/about/server.ts | Switches to inputValidator for server fn |
| package.json | Bumps deps, switches build output to dist, updates start/deploy scripts |
| .github/workflows/pnpm-lint-and-publish.yml | Updates deployment root and entrypoint to dist/server/server.js |
| .github/renovate.json | Removes rule disabling @TanStack package updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
32ed549 to
c7a3c16
Compare
Following a suggestion from copilot.
8a12692 to
eac595f
Compare
c144383 to
2dcac29
Compare
2dcac29 to
3ebf8c8
Compare
This reverts commit 60d65e0.
53a6411 to
2496907
Compare
2496907 to
b68883c
Compare
No description provided.