Skip to content

Migrate vue-app test project ESLint config to ESLint 10 flat config#11

Closed
Copilot wants to merge 2 commits intomasterfrom
copilot/convert-eslint-configuration
Closed

Migrate vue-app test project ESLint config to ESLint 10 flat config#11
Copilot wants to merge 2 commits intomasterfrom
copilot/convert-eslint-configuration

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 27, 2026

  • Analyze CI test failures
  • Identify root cause: @vue/cli-plugin-eslint@~5.0.0 only supports eslint@^6||^7||^8||^9, so bumping to ^10.1.0 caused ERESOLVE peer dep conflict
  • Migrate vue-app eslint legacy config (eslintConfig in package.json) to flat config (eslint.config.mjs)
  • Revert eslint back to ^9.17.0 (ESLint 9 supports flat config, and is the max feasible version for this project)
  • Add @eslint/js@^9.17.0 explicitly (needed for import js from '@eslint/js' in the flat config)
  • Remove legacy eslintConfig section from vue-app/package.json

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

@akurtakov
Copy link
Copy Markdown
Owner

@copilot investigate test failures

Copy link
Copy Markdown
Author

Copilot AI commented Mar 27, 2026

@copilot investigate test failures

The failure was caused by a peer dependency conflict: @vue/cli-plugin-eslint@~5.0.0 only supports eslint@^6||^7||^8||^9, so bumping eslint to ^10.1.0 caused an ERESOLVE error during npm install in the TestVue test setup.

Fixed in commit 5f97b90 by:

  • Reverting eslint back to ^9.17.0 in vue-app/package.json (ESLint 9 supports flat config — the PR goal "where feasible")
  • Adding @eslint/js@^9.17.0 as an explicit devDependency (needed for the import js from '@eslint/js' in the new eslint.config.mjs)

Copilot AI requested a review from akurtakov March 27, 2026 10:20
@akurtakov akurtakov closed this Mar 31, 2026
@akurtakov akurtakov deleted the copilot/convert-eslint-configuration branch March 31, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants