Skip to content

Fix ESLint proxy filename typo (eslipnt → eslint)#5

Closed
Copilot wants to merge 8 commits intomasterfrom
copilot/upgrade-eslint-server-version
Closed

Fix ESLint proxy filename typo (eslipnt → eslint)#5
Copilot wants to merge 8 commits intomasterfrom
copilot/upgrade-eslint-server-version

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 18, 2026

After the ESLint 3.0.24 upgrade was merged to master, the proxy JavaScript file was committed with a typo in its filename (eslipnt-lsp-proxy.js), while ESLintLanguageServer.java references it as eslint-lsp-proxy.js. This PR renames the file to match the Java reference, fixing a runtime failure.

  • eslint-lsp-proxy.js: Renamed from eslipnt-lsp-proxy.js to eslint-lsp-proxy.js to match the resource reference in ESLintLanguageServer.java

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: akurtakov <574788+akurtakov@users.noreply.github.com>
@akurtakov
Copy link
Copy Markdown
Owner

@copilot use version 3.0.20 for eslint-server-3.0.15.tgz so it matches.

Copilot AI changed the title [WIP] Upgrade ESLint language server to version 3.0.20 Upgrade ESLint language server to 3.0.20 Feb 18, 2026
Copilot AI requested a review from akurtakov February 18, 2026 22:34
Co-authored-by: akurtakov <574788+akurtakov@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Feb 18, 2026

@copilot use version 3.0.20 for eslint-server-3.0.15.tgz so it matches.

Updated the tgz reference to eslint-server-3.0.20.tgz in commit 2aaf8c1.

@akurtakov
Copy link
Copy Markdown
Owner

@copilot revert " use version 3.0.20 for eslint-server-3.0.15.tgz so it matches."

@akurtakov
Copy link
Copy Markdown
Owner

@copilot revert " use version 3.0.20 for eslint-server-3.0.15.tgz so it matches."

Copy link
Copy Markdown
Author

Copilot AI commented Mar 26, 2026

@copilot revert " use version 3.0.20 for eslint-server-3.0.15.tgz so it matches."

Reverted eslint-server-3.0.20.tgz back to eslint-server-3.0.15.tgz in commit c136741.

@akurtakov
Copy link
Copy Markdown
Owner

Copy link
Copy Markdown
Author

Copilot AI commented Mar 26, 2026

@copilot update to https://github.com/microsoft/vscode-eslint/releases/tag/release%2F3.0.24

Updated all references to 3.0.24 (git tag, VSIX URL, and tgz — which now all match since the server's package.json at that tag also uses version 3.0.24) in commit d5791f9.

Copilot AI changed the title Upgrade ESLint language server to 3.0.20 Upgrade ESLint language server to 3.0.24 Mar 26, 2026
@akurtakov
Copy link
Copy Markdown
Owner

@copilot investigate test failures

Copy link
Copy Markdown
Author

Copilot AI commented Mar 26, 2026

@copilot investigate test failures

All 4 TestESLint tests fail because vscode-eslint 3.x switched from diagnostic push (textDocument/publishDiagnostics) to pull (textDocument/diagnostic + workspace/diagnostic/refresh). LSP4E expects push, so no diagnostics arrive.

Fix in commit 123a25e:

  • Created eslint-lsp-proxy.js (following the md-lsp-proxy.js pattern) that intercepts the server's pull model and converts to push — removes diagnosticProvider from capabilities, pulls diagnostics after didOpen/didChange, and handles workspace/diagnostic/refresh from the server.
  • Updated ESLintLanguageServer.java to launch through the proxy.
  • Overrode refreshDiagnostics() in ESLintClientImpl to acknowledge refresh requests.
  • Fixed problems config to provide shortenToSingleLine: false instead of an empty map.

@akurtakov akurtakov marked this pull request as ready for review March 26, 2026 13:21
Use a proxy (like the markdown server one) to convert pull to push
diagnostics.
@akurtakov
Copy link
Copy Markdown
Owner

@copilot rebase on master

# Conflicts:
#	org.eclipse.wildwebdeveloper/src/org/eclipse/wildwebdeveloper/eslint/ESLintClientImpl.java

Co-authored-by: akurtakov <574788+akurtakov@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Mar 26, 2026

@copilot rebase on master

Merged master into the branch in commit ec3b57a. All ESLint 3.0.24 changes were already in master (commit 26b837f). The only remaining diff is fixing the proxy filename typo (eslipnt-lsp-proxy.jseslint-lsp-proxy.js) to match the reference in ESLintLanguageServer.java.

Copilot AI changed the title Upgrade ESLint language server to 3.0.24 Fix ESLint proxy filename typo (eslipnt → eslint) Mar 26, 2026
@akurtakov akurtakov closed this Mar 26, 2026
@akurtakov akurtakov deleted the copilot/upgrade-eslint-server-version branch March 26, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants