Add isLocked() to Storage and EventStore#312
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Agent-Logs-Url: https://github.com/albe/node-event-storage/sessions/3c57c789-88b9-4872-b4d2-35c1723b5b0f Co-authored-by: albe <4259532+albe@users.noreply.github.com>
Agent-Logs-Url: https://github.com/albe/node-event-storage/sessions/3c57c789-88b9-4872-b4d2-35c1723b5b0f Co-authored-by: albe <4259532+albe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no public API for clients to check whether a storage is currently locked by a writer — particularly useful for read-only consumers who want to know if a writer is active without attempting to acquire the lock themselves.
Changes
ReadableStorage: moveslockFilepath computation into the base class constructor (was only inWritableStorage); addsisLocked()returningfs.existsSync(this.lockFile).WritableStorage: removes now-redundantthis.lockFileassignment (inherited);lock()now usesisLocked()as the primary pre-check beforemkdirSync, with the EEXIST catch retained for the race-condition edge case.EventStore: addsisLocked()delegating tothis.storage.isLocked().Usage
Likewise available directly on
StorageandReadOnlyStorage: