Solving #37,#38,#29 and #10 - #46
Open
Subhiiiiii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description: Optimize Context Frame Handling in Unparser Rules
Key Changes in
UnparserRuleNode.java:Variable & Method Renaming
is_fragment→is_standaloneset_fragment()→set_standalone()Inverted Default Behavior
falsebut now indicates:Modifier Handling Update
Rules with modifiers now mark themselves as standalone:
Context Frame Logic Flip
Behavioral Impact:
✅ Performance Optimization
✅ Improved Semantics
standaloneflag clearly indicates intentional frame creation✅ Backward Compatibility
Verification Steps:
This change better aligns context frame management with actual parsing needs while maintaining existing functionality.