fix(lua): pass chunkname to codeload (E9)#36
Merged
Conversation
aldum
approved these changes
Jun 30, 2026
Collaborator
|
@Vadim1987 can you please rebase on the latest dev version? |
Vadim1987
force-pushed
the
Vadim1987/fix-codeload-chunkname
branch
from
38be37e to
fe1febb
Compare
Author
|
rebased on latest dev — resolved the codeload overlap with #27 (kept the type guard, added the chunkname). ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codeload called loadstring with no chunkname, so user code errors cited [string "…"] instead of the file. Add an optional name param and load with '@'..name, and pass the filename from load_file and ProjectService:run. Console input (no file) is left unnamed. NOTE: this touches the same codeload function as #27 (A5/C6) — #27 should be merged first; this branch will be rebased on top to resolve the overlap.