fix(input): balance the draw stack on early return (A2)#43
Merged
Conversation
Collaborator
|
This is to replace #39 |
aldum
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input render loop opens with
gfx.push('all')and has an early return in the middle (if not tl then return end) that skips the closinggfx.pop(). Whenever that branch is taken, one graphics stack level leaks per frame until LÖVE's stack depth cap is hit. The trigger is content whosestring.ulenis nil — see the companion PR for how such content gets in and for keeping it out at the model boundary; this change makes the draw scope exception-safe regardless of content, same shape as the use_canvas fix (#37).