Skip to content

fix: confirm dirty tabs before batch close - #243

Merged
alecdotdev merged 2 commits into
alecdotdev:masterfrom
PathGao:codex/fix-batch-close-confirmation
Jul 27, 2026
Merged

fix: confirm dirty tabs before batch close#243
alecdotdev merged 2 commits into
alecdotdev:masterfrom
PathGao:codex/fix-batch-close-confirmation

Conversation

@PathGao

@PathGao PathGao commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #242.

Summary

  • Route Close Others and Close to the Right through the existing save/discard/cancel flow.
  • Stop the batch immediately when a user cancels or a save fails, preserving all remaining tabs.

Validation

  • node --test --import tsx scripts/batchCloseConfirmation.test.ts
  • npm run check

@PathGao
PathGao marked this pull request as ready for review July 27, 2026 15:45
@alecdotdev

Copy link
Copy Markdown
Owner

i think a prior PR may have created a conflict. just at work but ready to merge when resolved

@PathGao
PathGao force-pushed the codex/fix-batch-close-confirmation branch from b2b4bf1 to afd4321 Compare July 27, 2026 19:38
@PathGao

PathGao commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@alecdotdev Thanks — I rebased #243 onto the current master and resolved the conflict while preserving the window-targeted listeners from #214. Its CI is running now.

Suggested merge order:

  1. ci: gate releases on complete platform artifacts #241 — already clean, with the full platform build matrix passing.
  2. fix: confirm dirty tabs before batch close #243 — once this current CI run passes.
  3. I will then rebase and submit the remaining independent reliability fixes one at a time: fix: constrain theme and image file paths #249 (path/input hardening), fix: ignore stale preview renders #254 (stale preview renders), fix: guard viewer initialization after disposal #258 (viewer disposal), and fix: recover from interrupted session restores #260 (interrupted restore recovery).

I would hold #225 and #226 for now. They are larger feature expansions still conflicted on the old #214 stack; after the independent fixes, I plan to do the no-behavior-change session/runtime componentization separately, then rebuild or rebase those features on the stable boundary.

@alecdotdev
alecdotdev merged commit 2d59129 into alecdotdev:master Jul 27, 2026
1 check passed
@PathGao
PathGao deleted the codex/fix-batch-close-confirmation branch July 29, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: preserve unsaved tabs in close-other and close-right commands

2 participants