fix: confirm dirty tabs before batch close - #243
Merged
alecdotdev merged 2 commits intoJul 27, 2026
Conversation
PathGao
marked this pull request as ready for review
July 27, 2026 15:45
Owner
|
i think a prior PR may have created a conflict. just at work but ready to merge when resolved |
PathGao
force-pushed
the
codex/fix-batch-close-confirmation
branch
from
July 27, 2026 19:38
b2b4bf1 to
afd4321
Compare
Contributor
Author
|
@alecdotdev Thanks — I rebased #243 onto the current master and resolved the conflict while preserving the window-targeted listeners from #214. Its CI is running now. Suggested merge order:
I would hold #225 and #226 for now. They are larger feature expansions still conflicted on the old #214 stack; after the independent fixes, I plan to do the no-behavior-change session/runtime componentization separately, then rebuild or rebase those features on the stable boundary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242.
Summary
Validation
node --test --import tsx scripts/batchCloseConfirmation.test.tsnpm run check