Revert "fix: constrain theme and image file paths" - #269
Merged
Conversation
This reverts commit 1923889.
Contributor
|
@alecdotdev Could you share the reason for reverting #249? I am preparing a smaller follow-up that preserves nested relative image directories while restoring the path and VSIX input boundaries. Knowing the concrete regression or compatibility concern will let me avoid repeating it. |
Owner
Author
|
@PathGao my apologies, I was merging the PRs in the sequence described here #249 (comment) and only then noticed that #265 should have been merged first, so I reverted. No issues with the PR itself, if you make another PR with the changes let me know and I'll review and merge. Thanks again for all your work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #249