refactor: move close decisions into document session - #278
Merged
alecdotdev merged 1 commit intoJul 30, 2026
Merged
Conversation
Contributor
Author
This was referenced Jul 30, 2026
PathGao
force-pushed
the
agent/extract-document-close-session
branch
5 times, most recently
from
July 30, 2026 05:09
25412b4 to
2f1b2cd
Compare
PathGao
force-pushed
the
agent/extract-document-close-session
branch
from
July 30, 2026 05:10
2f1b2cd to
cd277be
Compare
alecdotdev
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document close decisions now live with the document lifecycle that owns dirty state and saving. The viewer keeps presentation-only callbacks for the confirmation dialog and notifications, so the close behavior remains unchanged while future document work has one ownership boundary.
Depends on #277. Merge after it.
Validation
npm run checknpm test(119 passed)cargo test(20 passed)