Conversation
| "name": "all off", | ||
| "defaultDelay": 20, | ||
| "sequence": [ | ||
| [ "call", "lights off"], |
There was a problem hiding this comment.
I believe that if this was called macro it would be more intuitive.
There was a problem hiding this comment.
since the sequence is just a property of the macro, but not the macro itself, it would lead to less intuitive expressions on the code side. Although I see your point, I'd suggest to keep it.
| "lirc_web": "./app.js" | ||
| }, | ||
| "config": { | ||
| "test_env": true |
There was a problem hiding this comment.
Should this be set to false by default?
There was a problem hiding this comment.
as far as I have understood, this is applied only on calls of the script section. There we only have test calls and this default is exactly what we need.
|
Sorry for the delay. I took some time today and read through this. I appreciate how you refactored the macro engine, I do think this is a cleaner separation than how it was before. I also believe this could be a good step towards supporting additional communication protocols ( I'll attempt to run this on my raspberryPi, updating my Thanks! |
open: automatic resolving of virtual state dependency e.g. user triggers "Watch Bluray", blu-ray needs projector on, projector on needs lowered screen.