fixed potential bugs created by manual impel and code smells#2895
Open
jhonDoe15 wants to merge 6 commits intoalibaba:masterfrom
Open
fixed potential bugs created by manual impel and code smells#2895jhonDoe15 wants to merge 6 commits intoalibaba:masterfrom
jhonDoe15 wants to merge 6 commits intoalibaba:masterfrom
Conversation
…o try with resources, removed redundent assignment for clarity
|
|
jhonDoe15
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed potential bugs created by manual impel
Describe what this PR does / why we need it
data streams closed manually, breaking SOLID principals making code unclear (assigning a variable for no need)
Does this pull request fix one issue?
Fixed NONE
Describe how you did it
replaced java anti-patterns usage and cleaned code
Describe how to verify it
human review
Special notes for reviews
It looks like a fantastic project to get into and use, looking forward to it.