Skip to content

fix: isolate external projects from host toolchain library paths #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suxiaogang223 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix: isolate external projects from host toolchain library paths #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,14 @@ set(EP_COMMON_CMAKE_ARGS
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
-DCMAKE_CXX_FLAGS=${EP_CXX_FLAGS}
-DCMAKE_C_FLAGS=${EP_C_FLAGS}
-DCMAKE_INSTALL_LIBDIR=lib)
-DCMAKE_INSTALL_LIBDIR=lib
# Prevent leaking host toolchain library/include paths into external
# project builds. Without these, cmake may find incompatible libraries
# (e.g. a partial libunwind.so from a toolchain) that cause runtime
# symbol lookup errors. All external project dependencies are passed
# explicitly via xxx_ROOT/xxx_HOME variables.
-DCMAKE_LIBRARY_PATH=
-DCMAKE_PREFIX_PATH=)

if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.30")
list(APPEND EP_COMMON_CMAKE_ARGS -DCMAKE_POLICY_VERSION_MINIMUM=3.5)
Expand Down
Loading