Rebuild chess game with tested rules and Swing UI - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A critical timeout-result issue and a moderate promotion-history issue remain unresolved.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Rebuilds the prototype into a tested chess rules engine with a refreshed Swing UI.
Changes:
- Adds legal moves, special moves, game-end detection, clocks, history, and controls.
- Adds headless tests and build/run scripts.
- Removes obsolete prototype classes and updates documentation.
Review findings:
ChessApp.java:445— Critical: timeout results need a dead-position/mating-material check; 1 vote.ChessApp.java:413— Moderate: knight promotion history should useN, notK; 1 vote.
| File | Description |
|---|---|
TestGraphics.java |
Removes prototype preview |
test.sh |
Test runner |
run.sh |
Application launcher |
README.md |
Usage and project documentation |
Piece.java |
Removes prototype piece logic |
MouseMotion.java |
Removes prototype input handling |
ImageCreater.java |
Removes prototype image loader |
ChessGameTest.java |
Headless rule tests |
ChessGame.java |
Standalone chess rules engine |
Chessclock.java |
Removes prototype clock |
Chessboard.java |
Removes prototype board |
ChessApp.java |
Swing interface, clocks, and controls |
build.sh |
Runnable JAR build script |
.vscode/settings.json |
Removes obsolete editor settings |
.gitignore |
Ignores generated files |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Verification
./test.sh— 10 tests passed.javac -Xlint:all -encoding UTF-8 -d /tmp/chessgamejava-final-lint ChessGame.java ChessApp.java ChessGameTest.java— clean.Known limitation
Draws by repetition and the fifty-move rule are not detected automatically.
mainis protected and requires a pull request and verified commit signatures. The pushed commit is unsigned because this machine has no GitHub signing key configured.