Repository navigation
Say how many files Validate checked, including none - #138
Merged
Merged
Conversation
Files that pass validation get no row, and the status came from the row count, so it read "0 files do not have the correct encoding" both when every file passed and when a mistyped mask matched nothing. The window now counts every file the scan reports. The status reads "No matching files were examined", "Checked N files: all valid", or "Checked N files: X do not have the correct encoding", adding "Y could not be read" for files the scan could not open. Exclusion coverage is still appended. Tests feed real Validate scans into the same count: no match, an empty folder, all valid, and a mix with a file held open. Three counting mutations fail them. The form wiring is two lines checked by reading; the GUI smoke suite does not run Validate. Backlog: BL-40. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the GUI, files that pass Validate are not added to the list, and the status was built from the row count. It read "0 files do not have the correct encoding" both when every file passed and when a mistyped mask matched nothing, so a clean result could stand in for a check that never ran. Found in the 2026-09-20 review (F3), from the source.
Change
ValidationTallycounts every file the scan reports, from the scan's worker threads (Interlocked), including files that pass and so get no row.No matching files were examinedChecked N files: all validChecked N files: X do not have the correct encoding, plus, Y could not be readwhen the scan could not open some files.Tests
ValidationStatusTestsfeeds real Validate scans into the same tally the window uses:FileShare.None: "Checked 3 files: 1 do not have the correct encoding, 1 could not be read";Mutation checks (each restored byte-for-byte afterwards)
Limits
Verification
masterafter Restore source choices when a GUI review ends without writing #137. Release build, 0 warnings; 975/975 tests pass.docs/Test-DefectBacklog.ps1passes.🤖 Generated with Claude Code