Repository navigation
remote_cache: Refuse an empty signing certificate - #298
Merged
Merged
Conversation
A builder whose certificate file is empty signs results without a certificate, because the signer reads an empty file as no certificate at all. The signer then also skips the check that the certificate outlives the results. Parse the certificate file whenever it is configured, so an empty file fails like any other unusable certificate. Signed-off-by: Daan De Meyer <daan@amutable.com>
martinpitt
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A builder whose certificate file is empty signs results without a
certificate, because the signer reads an empty file as no certificate at
all. The signer then also skips the check that the certificate outlives the
results. Parse the certificate file whenever it is configured, so an empty
file fails like any other unusable certificate.
Signed-off-by: Daan De Meyer daan@amutable.com