dirname() breaks urls on windows

[karpour]

dirname() seems to be specifically meant for local filesystem operations. On windows, it adds a '\' at the beginning of the returned string, breaking URLs, since the resulted absolute URL looks like http://site.tld/\dirname/ then.

'/' . basename(...) seems to work as a replacement that also works on Windows

[coveralls]

Coverage remained the same at 97.405% when pulling a0f0bb4 on karpour:master into 23f2175 on andreskrey:master.

[coveralls]

Coverage remained the same at 97.405% when pulling a0f0bb4 on karpour:master into 23f2175 on andreskrey:master.

[andreskrey]

Seems that your change is breaking the tests. Can you take a look at it?

The main problem I see is that the url your change generates has the file path (index.html for example) when it should end at the folder level.

[karpour]

Yeah, seems, basename isn't the way to go. I can't run the tests atm since in a Windows machine, they won't pass in the first place.
All these functions are meant for local files, not URLs. I'll have a look at it again and see if there's any built-in function that handles everything with forward slashes.

Could simply replace the first character if dirname() with '/', but dirname() doesn't actually always return a string starting with '/', so counting on that would be a mistake as well and it would be a dirty solution.