verifier_tools/verify: Add 2026/01 shard target for google_1p_code log - #30
Merged
Merged
Conversation
Previously, `--log_type=google_1p_code` only targeted the legacy log at `developers.google.com/android/binary_transparency/google1p` (frozen at tree size 134), causing verification to fail for entries published to the active `2026/01` shard (`gstatic.com/android/binary_transparency/google1p/jwt/2026/01`). Update `google_1p_code` verification to cover both shards: 1. Add `gstatic.com/android/binary_transparency/google1p/jwt/0` to the supported checkpoint origins in `internal/checkpoint/checkpoint.go`. 2. Configure `google_1p_code (2026/01)` as the primary target in `cmd/verifier/verifier.go` with `tileHeight: 8` and verifier key name `gstatic.com/android/binary_transparency/google1p/jwt/0` (using the embedded `log_pub_key.google_system_apk.pem` public key). 3. Retain `google_1p_code (legacy)` (`tileHeight: 1`) as a fallback target so entries from the original log continue to verify. Test: - `cd verifier_tools/verify && go test -v ./...` - Added `cmd/verifier/verifier_test.go` (`TestResolveTargetsGoogle1PCode` and `TestGoogle1PCodeCheckpointSignatureVerification`) as well as test cases in `checkpoint_test.go` and `reader_test.go`. - Verified inclusion proof against both `2026/01` and legacy `google_1p_code` log entries. Change-Id: I270e6a356b646659cfe645d0006fd006d5c0b9e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
--log_type=google_1p_codeonly targeted the legacy log atdevelopers.google.com/android/binary_transparency/google1p(frozen at tree size 134), causing verification to fail for entries published to the active2026/01shard (gstatic.com/android/binary_transparency/google1p/jwt/2026/01).Update
google_1p_codeverification to cover both shards:gstatic.com/android/binary_transparency/google1p/jwt/0to the supported checkpoint origins ininternal/checkpoint/checkpoint.go.google_1p_code (2026/01)as the primary target incmd/verifier/verifier.gowithtileHeight: 8and verifier key namegstatic.com/android/binary_transparency/google1p/jwt/0(using the embeddedlog_pub_key.google_system_apk.pempublic key).google_1p_code (legacy)(tileHeight: 1) as a fallback target so entries from the original log continue to verify.Test:
cd verifier_tools/verify && go test -v ./...cmd/verifier/verifier_test.go(TestResolveTargetsGoogle1PCodeandTestGoogle1PCodeCheckpointSignatureVerification) as well as test cases incheckpoint_test.goandreader_test.go.2026/01and legacygoogle_1p_codelog entries.Change-Id: I270e6a356b646659cfe645d0006fd006d5c0b9e1