Skip to content

fix: add name property to OpCode for mypy not to complain when accessing it#252

Merged
mborgerson merged 1 commit intoangr:masterfrom
toby-bro:fix/add_name_attribute_for_opcodes
Mar 28, 2026
Merged

fix: add name property to OpCode for mypy not to complain when accessing it#252
mborgerson merged 1 commit intoangr:masterfrom
toby-bro:fix/add_name_attribute_for_opcodes

Conversation

@toby-bro
Copy link
Copy Markdown
Contributor

@toby-bro toby-bro commented Mar 27, 2026

Mypy kept complaining when I accessed the name attribute of OpCode even though it is present in the C++ code (thanks to nanobind nb::enum_ type)
So made it a class property.

@toby-bro toby-bro force-pushed the fix/add_name_attribute_for_opcodes branch from c1c9af7 to bcd6535 Compare March 27, 2026 22:44
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.57%. Comparing base (7b16cb0) to head (bcd6535).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files           5        5           
  Lines         514      514           
  Branches       82       82           
=======================================
  Hits          445      445           
  Misses         27       27           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mborgerson mborgerson merged commit 96c4c04 into angr:master Mar 28, 2026
35 checks passed
@mborgerson
Copy link
Copy Markdown
Member

Thanks!

toby-bro added a commit to toby-bro/microtaint that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants