Skip to content

fix: explicitly depend on tslib#338

Open
ibacher wants to merge 1 commit into
angular-architects:mainfrom
ibacher:add-explicit-tslib
Open

fix: explicitly depend on tslib#338
ibacher wants to merge 1 commit into
angular-architects:mainfrom
ibacher:add-explicit-tslib

Conversation

@ibacher

@ibacher ibacher commented Jun 28, 2023

Copy link
Copy Markdown

I'm trying to use this with Yarn's Plug'n'Play feature, which requires some explicitness about libraries. Since these libraries are build with "importHelpers": true, the resulting built code looks something like this (from build.js in @softarc/native-federation):

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const tslib_1 = require("tslib");
tslib_1.__exportStar(require("./src/build"), exports);

The attempt to use tslib without an explicit dependency on tslib in the package.json—it's a dependency of the monorepo—causes a Yarn error when trying to execute the require("tslib").

Thanks for all the work on this library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant