revert(@angular/cli): import markdown files directly for command descriptions - #34109
Merged
Merged
Conversation
…mmand descriptions" This reverts commit 3d7f081.
alan-agius4
added
target: rc
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors how long descriptions (Markdown files) are loaded for Angular CLI commands. It removes the custom markdown loader hook and direct imports of .md files, replacing them with a longDescriptionPath property on command modules to dynamically read the files at runtime. The review feedback highlights an issue with the relative path calculation in command-module.ts, which omits the @angular/cli/ prefix and resolves to angular/cli/src/commands/... instead, potentially breaking documentation generation tools.
clydin
approved these changes
Sep 17, 2026
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts commit 3d7f081 in 22.2.x.