Skip to content

refactor(@angular/cli): remove unused example database path from MCP server - #34111

Merged
clydin merged 1 commit into
angular:mainfrom
clydin:refactor/mcp-remove-example-db-path
Sep 17, 2026
Merged

clydin merged 1 commit into
angular:mainfrom
clydin:refactor/mcp-remove-example-db-path

Conversation

@clydin

@clydin clydin commented Sep 17, 2026

Copy link
Copy Markdown
Member

Removes the unused exampleDatabasePath property from McpToolContext and its instantiation in mcp-server.ts, which were leftover from the removal of the find_examples MCP tool. Also removes the unused join import.

…server

Removes the unused exampleDatabasePath property from McpToolContext and its instantiation in mcp-server.ts, which were leftover from the removal of the find_examples MCP tool. Also removes the unused join import.
@clydin clydin added the target: minor This PR is targeted for the next minor release label Sep 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused exampleDatabasePath property from the McpToolContext interface in tool-registry.ts and its corresponding initialization in mcp-server.ts. Additionally, it cleans up the unused join import from node:path. There are no review comments, and I have no feedback to provide.

@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 17, 2026
@clydin
clydin requested a review from alan-agius4 September 17, 2026 17:23
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 17, 2026
@clydin
clydin merged commit f521955 into angular:main Sep 17, 2026
43 checks passed
@clydin

clydin commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

@clydin
clydin deleted the refactor/mcp-remove-example-db-path branch September 17, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/cli target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants