Skip to content

fix(@angular/build): ensure chokidar watcher is ready before returning #34122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 2 commits into from
Sep 18, 2026
Merged

fix(@angular/build): ensure chokidar watcher is ready before returning #34122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f22bff9
fix(@angular/build): ensure chokidar watcher is ready before returning
alan-agius4 Sep 18, 2026
ad6a6ca
fixup! fix(@angular/build): ensure chokidar watcher is ready before r…
alan-agius4 Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/angular/build/src/builders/dev-server/tests/behavior/build-errors_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ describeServeBuilder(executeDevServer, DEV_SERVER_BUILDER_INFO, (harness, setupT
expectNoLog(logs, 'Unexpected character "EOF"');
},
],
{ outputLogsOnFailure: false, timeout: 90_000 },
{ outputLogsOnFailure: false },
);
}, 120_000);
});
});
});
8 changes: 8 additions & 0 deletions packages/angular/build/src/tools/esbuild/watcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import type * as ParcelWatcher from '@parcel/watcher';
import type * as Chokidar from 'chokidar';
import { once } from 'node:events';
import * as fs from 'node:fs';
import * as path from 'node:path';
import picomatch from 'picomatch';
Expand Down Expand Up @@ -663,8 +664,15 @@ async function createChokidarWatcher(
usePolling: !!options?.polling,
interval: options?.interval,
});

const initTime = Date.now();

// Wait for the watcher to complete its initial filesystem scan before returning.
// With `ignoreInitial: true`, any file visited during the initial scan is treated as the initial baseline
// and will not emit 'add' or 'change' events. Awaiting 'ready' ensures that rapid file modifications
// made right after watcher setup (e.g. in rebuild tests) are not swallowed as initial files.
await once(watcher, 'ready');

const handleEvent = (type: 'added' | 'modified' | 'removed', rawPath: string) => {
const posixPath = toPosixPathNormalized(rawPath);
const lookupKey = toLookupKey(posixPath, isCaseSensitive);
Expand Down
Loading