Repository navigation
Conversation
…ledBefore in refactor-jasmine-vitest
The `toHaveBeenCalledBefore` transformation rewrites the matcher to a comparison of
`vi.mocked(spy).mock.invocationCallOrder` values but never registers `vi` as a pending
value import. When the schematic runs with `--add-imports`, the migrated file only
imports `expect` and fails to compile with "Cannot find name 'vi'" unless another
transformation in the same file happens to use `vi`.
Register the `vi` import when the matcher is transformed, as every other transformation
that emits `vi.*` already does.
The new spec fails without the fix: the migrated output contained
`import { expect } from 'vitest'` instead of `import { expect, vi } from 'vitest'`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Jasmine-to-Vitest refactoring transformer to ensure that the 'vi' import is correctly added when transforming 'toHaveBeenCalledBefore' matchers. Specifically, it passes 'pendingVitestValueImports' to 'transformToHaveBeenCalledBefore' and calls 'addVitestValueImport' to register the 'vi' import. A corresponding unit test has also been added to verify this behavior. There are no review comments, so I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
toHaveBeenCalledBeforetransformation rewrites the matcher to a comparison ofvi.mocked(spy).mock.invocationCallOrdervalues but never registersvias a pending value import. When the schematic runs with--add-imports, the migrated file only importsexpectand fails to compile with "Cannot find name 'vi'" unless another transformation in the same file happens to usevi.Register the
viimport when the matcher is transformed, as every other transformation that emitsvi.*already does.The new spec fails without the fix: the migrated output contained
import { expect } from 'vitest'instead ofimport { expect, vi } from 'vitest'.