Fix false Codecov project coverage drops by uploading R and JS reports together (#254)

[Nishita-shah1]

Fixes #254

Summary

• Codecov project was failing on documentation-only commits because R and JS coverage were uploaded separately. If the JS job failed, an R-only report became the baseline, so the next full R+JS upload looked like a coverage drop.
• Coverage jobs now save artifacts instead of uploading immediately. A follow-up job uploads both reports together, and only if both R and JS jobs succeed.
• CRAN checks stay in their own job. Texlive is installed only there.

Test plan

• Confirm CI runs R_coverage and JS_coverage in parallel, then Upload combined coverage to Codecov.
• Confirm the combined upload job is skipped if either coverage job fails.
• Confirm CRAN still runs independently.
• On the PR, Codecov patch and project should not fail just because one coverage job failed on a previous commit.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.07%. Comparing base (8f009ed) to head (a2bb257).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files         165      165           
  Lines        8933     8933           
=======================================
  Hits         6528     6528           
  Misses       2405     2405           

Flag	Coverage Δ
javascript	?
r	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tdhock]

@ANAMASGARD please review?

[ANAMASGARD]

@Nishita-shah1 the combined coverage upload approach looks correct for #254. I left a few inline comments
after these changes, could you please verify one failure case where either coverage job fails and the Codecov upload is skipped, followed by a docs-only/no-code-change run showing 0.00% project coverage change? that would confirm #254 end-to-end.

[ANAMASGARD]

@Nishita-shah1 after removing Texlive from the coverage jobs, this test skips there. The CRAN job has Texlive, but build.sh uses filter="compiler", so this renderer test is not selected there either.

could we please keep this test running in at least one CI job, so the coverage test scope remains consistent with master?

[ANAMASGARD]

sorry, my earlier suggestion missed the normal test setup. test_file() sources the helpers directly, but animint2 is not loaded, so toRGB() is unavailable. could we load the same packages as tests/testthat.R before running this test?

Suggested change

	- name: run PDF renderer test
	run: Rscript -e 'testthat::test_file("tests/testthat/test-renderer3-knit-print-pdf.R")'
	- name: run CRAN build
	run: bash build.sh
	- name: run PDF renderer test
	run: Rscript -e 'library(testthat); library(animint2); library(XML); test_file("tests/testthat/test-renderer3-knit-print-pdf.R")'
	- name: run CRAN build
	run: bash build.sh

[ANAMASGARD]

Sir @tdhock the PR now looks good can you please give it a last review before merge .