Assignments done by Vladislav Morozov#8
Open
zeronumbers wants to merge 21 commits intoanko-code-academy:mainfrom
Open
Assignments done by Vladislav Morozov#8zeronumbers wants to merge 21 commits intoanko-code-academy:mainfrom
zeronumbers wants to merge 21 commits intoanko-code-academy:mainfrom
Conversation
zeronumbers
force-pushed
the
assignments
branch
from
bd6384e to
8212355
Compare
zeronumbers
force-pushed
the
assignments
branch
from
8212355 to
a1c0dc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignments
Checklist
Notes
The test code for 07 is taken from: 81a8b74#diff-e91e51c59d93f543f2d2a72f79e93acee1dd14eae23706768fe03c856139a657
As discussed I ignore code style requirement.
I don't know the type system that is written in the comment (maybe jshint), so my functions don't have type comments.
Because I had separate branches for each commit I created another branch and cherry picked commits into it. I will commit the rest files to this branch later.
Commits for assignments 02 and 16 don't have
:in title of commit due to typos.There is an extra commit with a fix, I forgot to remove
console.login assignment 16.