fix(pty): make terminal cleanup complete under backpressure - #15
Open
jlongster wants to merge 4 commits into
Open
fix(pty): make terminal cleanup complete under backpressure#15jlongster wants to merge 4 commits into
jlongster wants to merge 4 commits into
Conversation
jlongster
force-pushed
the
conpty-runtime
branch
from
September 3, 2026 17:48
3a1d57d to
64427e2
Compare
jlongster
force-pushed
the
conpty-cleanup
branch
from
September 3, 2026 17:48
81db79a to
c92abf2
Compare
jlongster
marked this pull request as ready for review
September 3, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2 — termination and cleanup
Complete at c92abf2, stacked on P1 #12 / conpty-runtime64427e2, above corrected T2 windows-pipes3ebd4a5. Source is frozen for T3 convergence. Do not merge.
Runtime changes
Exact-head verification
Windows run33786722949: native x64 AND ARM64 each passed29 library +5 callback +12 real runtime +1 retained-pointer tests (47 total), plus standalone library29/29. Architecture/PE checks, formatting, locked all-target/all-feature Clippy, build and executable smoke all passed.
Core run33786723170: Linux61 tests, macOS56, Miri5 callback +1 retained-pointer in BOTH Stacked and Tree Borrows modes, all passed. One ignored runtime test is the deliberately self-spawned fixture entry.
Runtime coverage includes natural exit/final-output ordering, exit259, strict live-captured root/PowerShell-descendant process handles, repeated termination/drop, non-reading Windows children and active-output shutdown. Combined T3 daemon coverage is tracked separately in #16.
Preserved limitations/evidence