fix(pty): complete terminal subscription lifecycle - #18
Open
jlongster wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
Both subscription fixes are complete and reviewed. This head passed ordinary native x64/ARM64 (63 tests plus standalone38 each), Linux65/macOS60 and Miri6+6. The final stack in #19 also passes its ordinary native/Core suites and all eight focused regressions on x64. The extra final ARM64 focused job timed out during compilation before running probes; that explicit verification gap and the final evidence links are documented in #19. No further optional retries or merges are being performed. |
jlongster
marked this pull request as ready for review
September 3, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrated subscription fixes
Stacked above #17 / windows-verification at 9f8f85c; lower branches remain frozen and unmerged.
Four small regressions cover late completion/final offset, retained receiver clones with one-slot queues, stale-ID detach, and failed-observer removal before fallback. Extensive probes/generators are not committed.
A separate test-only commit changes the existing foreground fixture to
tail --pid=$$ -f /dev/null & sleep 5; every assertion/timing remains unchanged. This ties its background child to the owned shell, not a claimed repair or explanation of prior CI hangs.Verification
Scope remains the demonstrated controller-send/actor-queue cycle; this does not promise ordinary detach bypasses unrelated native/writer stalls. The excluded Linux blocked-master-write limitation is unchanged.