Repository navigation
Conversation
Collaborator
Author
|
This was folded into anomalyco/opencode#59694. The ported Windows workflow no longer saves the cache from failed runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache-on-failure: truefrom theSwatinem/rust-cachestep in the Windows workflow, so it falls back to the action's default (false) and only successful jobs save a cache.cache-on-failurestill let it save a cache entry. That entry was about half the normal size (~226 MB vs ~523 MB). The re-run restored the partial cache and hung again. Deleting that entry fixed it. With this change, a failed, cancelled or timed-out run can no longer save a broken cache.core.ymluses rust-cache withoutcache-on-failure, andpublish.ymldoesn't use rust-cache, so neither needs a change.Validation
ruby -ryaml -e 'YAML.load_file(".github/workflows/windows.yml")'parses the workflow.