fix: do not merge permissions objects, merge rulesets#23214
Open
asuffield wants to merge 1 commit intoanomalyco:devfrom
Open
fix: do not merge permissions objects, merge rulesets#23214asuffield wants to merge 1 commit intoanomalyco:devfrom
asuffield wants to merge 1 commit intoanomalyco:devfrom
Conversation
…erve permissions objects as layers, convert them individually to rulesets, and merge the rulesets (anomalyco#16157)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16157
Type of change
What does this PR do?
merging permissions objects will discard ordering. instead, preserve permissions objects as layers, convert them individually to rulesets, and merge the rulesets
How did you verify your code works?
added tests to cover the interesting scenarios, which now pass and did not before
Checklist