feat: add Activity Indicators setting to control session progress bar animation#23229
Open
jasonmj wants to merge 4 commits intoanomalyco:devfrom
Open
feat: add Activity Indicators setting to control session progress bar animation#23229jasonmj wants to merge 4 commits intoanomalyco:devfrom
jasonmj wants to merge 4 commits intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
The animated progress bar that runs across the top of the session header while a session is active is distracting for some users. There was no way to disable it.
This adds a boolean setting
showSessionProgress(defaulttrue) to the general settings store, wires it to a Switch toggle in Settings → General → Appearance labelled "Activity Indicators", and gates thesession-progressbar render on that value inmessage-timeline.tsx. The spinner next to the session title is not affected. i18n keys are added to all 17 locale files with English strings as placeholders for non-English locales.How did you verify your code works?
bun test --cwd packages/app ./src/i18n/parity.test.ts— 1 pass, 0 failScreenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist